Conversation
Define CoordinateSpace enum (WORLD_CENTERED, WORLD_POSITIVE) and CoordinateTransform utilities for converting positions between spaces. Integrate into CognitiveWaveform to normalize agent positions before peak/ridge calculations. Add coordinateSpace property to AgentLayer with getAgentPositionIn/getAgentPosition3DIn accessors. All changes are additive with backward-compatible defaults. Includes comprehensive unit tests and full-scene integration tests verifying heightfield consistency across coordinate spaces. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
wow-miley
deleted the
email/pho-6-phosphor-unify-coordinate-spaces-between-agentlayer-and
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves PHO-6 by defining an explicit coordinate-space contract and implementing conversion utilities. The waveform now correctly handles agents positioned in either WORLD_CENTERED or WORLD_POSITIVE coordinate spaces, ensuring visual alignment of peaks with agent nodes on all rendering surfaces.
Changes
coordinatepackage withCoordinateSpaceenum andCoordinateTransformutilities for bidirectional conversion between coordinate spacesagentCoordinateSpaceparameter;addAgentPeakandaddFlowRidgesnormalize agent positions before comparisongetAgentPositionInandgetAgentPosition3DInon AgentLayer for converting positions to any target spaceAll changes are additive with backward-compatible defaults; no existing behavior changed.
🤖 Generated with Claude Code